[Bug 562504] Review Request: mpi4py - Python bindings of the Message Passing Interface (MPI)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=562504

--- Comment #14 from Thomas Spura <tomspur at fedoraproject.org> 2010-02-16 13:14:41 EST ---
(In reply to comment #13)
> Hi, I'm the author of mpi4py and a Fedora user since the project started. I
> would like to make some comments on the way mpi4py is being packaged and
> propose some cleanups in the spec file.

I could not find you in FAS, so I assume, you are not in the packager group. If
so, you could co-maintain this package (or I co-maintain it ;) ).

> 1) Please DO NOT REMOVE all empty pyx/pxd files!

Didn't know that about the cython support. Atm, I just use python.
I deleted that part.

> 2) I would remove the whole 'docs/source/slides' directory. BTW, the contents
> of 'docs/source/usrman' are the reST sources from which the 'docs/usrman/*'
> HTML documentation (and 'docs/mpi4py.pdf') are generated (using Sphinx and
> Latex)... So perhaps the whole directory 'docs/source' could be removed, though
> the  almost-plain-text reST sources at 'docs/source/usrman' could be handy.

docs/source deleted.

> 3) mpi4py's custom, distutils-based buildsystem (conf/mpidistutils.py) already
> handles MPI compiler wrappers mpicc/mpicxx (as long as they can be found in
> $PATH), so there is not need to "export CC=mpicc CXX=mpicxx".

According to http://fedoraproject.org/wiki/PackagingDrafts/MPI
that should be there. Furthermore this does not destroy something, so I leave
it there, untill Jussi disagrees.

> 4) mpi4py DO SUPPORT Python 3. Moreover, the testsuite should also run and all
> tests pass. Of course, about half the tests will not run because of missing
> numpy, but the other half will use Python's builtin "array.array" instances.    

Yes, unfortunately there were some issues on the buildsystem with the tests.
The mpich tests can't be run, because of the mpd issue, so I'll run them here
locally and try to run the rest olso on the buildsystem, but they failed
completely:
"""
It looks like orte_init failed for some reason; your parallel process is
likely to abort.  There are many reasons that a parallel process can
fail during orte_init; some of which are due to configuration or
environment problems.  This failure appears to be an internal failure;
here's some additional information (which may only be relevant to an
Open MPI developer):
  orte_plm_base_select failed
  --> Returned value Not found (-13) instead of ORTE_SUCCESS
"""

-> Disabled completely. Furthermore the testsuite runs just fine on my system.

Thanks for your suggestions and infomations :)

Spec URL: http://tomspur.fedorapeople.org/review/mpi4py.spec
SRPM URL: http://tomspur.fedorapeople.org/review/mpi4py-1.2-6.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.