[Bug 565902] Review Request: csync - a bidirectional file synchronizer for roaming home directories

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=565902

Terje Røsten <terjeros at phys.ntnu.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |terjeros at phys.ntnu.no

--- Comment #6 from Terje Røsten <terjeros at phys.ntnu.no> 2010-02-17 03:48:45 EST ---
Links to updated spec and srpm, please. koji scratch build would be nice too:

 http://fedoraproject.org/wiki/PackageMaintainers/UsingKoji#Scratch_builds_2

Some comments

 - the empty # lines looks strange
 - you don't need to repeat License: tag in subpackage if everything is
   under identical license
 - you might want to change 
    Requires:       libcsync = %{version}
    Requires:       libcsync = %{version}-%{release}
 - I believe defattr should changed 
    %defattr(-,root,root) ->  %defattr(-,root,root,-)
 - change all %__foo macros to %{__foo}
 - remove gcc-c++ from buildreq
 - tags are in strange order
 - is source1 of any use?
 - bump release and add changelog when doing changes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.