[Bug 565902] Review Request: csync - a bidirectional file synchronizer for roaming home directories

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=565902

--- Comment #7 from Andreas Schneider <asn at redhat.com> 2010-02-17 08:24:51 EST ---
(In reply to comment #6)
> Links to updated spec and srpm, please. koji scratch build would be nice too:

Spec URL: http://www.cynapses.org/tmp/rpm/csync.spec
SRPM URL: http://www.cynapses.org/tmp/rpm/csync-0.44.0-2.fc12.src.rpm
Koji URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=1993331

> Some comments
> 
>  - the empty # lines looks strange

I've removed them.

>  - you don't need to repeat License: tag in subpackage if everything is
>    under identical license

I've removed them too.

>  - you might want to change 
>     Requires:       libcsync = %{version}
>     Requires:       libcsync = %{version}-%{release}

Done.

>  - I believe defattr should changed 
>     %defattr(-,root,root) ->  %defattr(-,root,root,-)

Done.

>  - change all %__foo macros to %{__foo}

I don't see a reason for this, only if the macro would support options.

>  - remove gcc-c++ from buildreq

Done.

>  - tags are in strange order

Is there a rule for the order?

>  - is source1 of any use?

Sure, you can verify that the source archive hasn't been modified.

gpg --verify csync-0.44.0.tar.gz.asc

It is like a md5sum but cryptographic secured.

They are included in other SRPMS of Fedora too. See libssh for example.

>  - bump release and add changelog when doing changes    

Done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.