[Bug 566688] Review Request: perl-MooseX-Types-DateTime-ButMaintained - DateTime related constraints and coercions for Moose

bugzilla at redhat.com bugzilla at redhat.com
Sat Feb 20 08:13:31 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=566688

--- Comment #1 from Iain Arnell <iarnell at gmail.com> 2010-02-20 03:12:46 EST ---
Fails to build in mock (locally, with perl-Olson-Abbreviations installed).
There's either a missing BR on perl(CPAN), or you can run Makefile.PL with
PERL5_CPANPLUS_IS_RUNNING=1 to avoid CPAN entirely.

Some of the requires in the spec are unnecessary:
perl(DateTime)  
perl(DateTime::Locale)  
perl(DateTime::TimeZone)  
perl(Olson::Abbreviations)  

Otherwise, it's looking good.

Source tarballs match upstream
7dacf16bfedf3910247000e006be5b15 
MooseX-Types-DateTime-ButMaintained-0.11.tar.gz

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

rpmlint is almost silent (only complains about stupid spelling errors)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list