[Bug 566688] Review Request: perl-MooseX-Types-DateTime-ButMaintained - DateTime related constraints and coercions for Moose

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=566688

--- Comment #2 from Marcela Mašláňová <mmaslano at redhat.com> 2010-02-22 04:03:58 EST ---
(In reply to comment #1)
> Fails to build in mock (locally, with perl-Olson-Abbreviations installed).
> There's either a missing BR on perl(CPAN), or you can run Makefile.PL with
> PERL5_CPANPLUS_IS_RUNNING=1 to avoid CPAN entirely.
> 
Great macro!
> Some of the requires in the spec are unnecessary:
> perl(DateTime)  
> perl(DateTime::Locale)  
> perl(DateTime::TimeZone)  
> perl(Olson::Abbreviations)  
>
Removed. 
> Otherwise, it's looking good.
> 
> Source tarballs match upstream
> 7dacf16bfedf3910247000e006be5b15 
> MooseX-Types-DateTime-ButMaintained-0.11.tar.gz
> 
> Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
> make test passes cleanly.
> 
> rpmlint is almost silent (only complains about stupid spelling errors)    

http://mmaslano.fedorapeople.org/review/perl-MooseX-Types-DateTime-ButMaintained-0.11-2.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.