[Bug 551838] Review Request: opendchub - A hub software for Direct Connect

bugzilla at redhat.com bugzilla at redhat.com
Thu Jan 7 16:57:01 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=551838





--- Comment #7 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2010-01-07 11:57:00 EDT ---
(In reply to comment #6)
> (In reply to comment #5)
> Done! The very next line in the above links says "packages link to libperl.so,
> usually to provide embedded perl functionality. All of these packages must also
> use the versioned MODULE_COMPAT Requires. " So I think this is needed as well
> 
> Requires:  perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))

- Because none of the binaries in this package are linked against
  libperl.so and this package does not contain any perl scripts,
  this Requires is not needed.

> > * creating directory under home directory
> I have done this by 
> 
> %build
> %configure --enable-switch_user
> rm -rf $HOME/.opendchub
> 
> Is it okay ?

- This is still undesired when rebuilding this srpm with usual rpmbuild
  because this actually removes ~/.opendchub, which may already be used
  by the user.
  You should apply a patch against configure.in not to create these
  directories and call autotools.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list