[Bug 548522] Review Request: autotest-client - Autotest is a framework for fully automated testing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=548522

--- Comment #7 from James Laska <jlaska at redhat.com> 2010-01-11 17:14:26 EST ---
(In reply to comment #6)
> Is it really a webservice? It does not look like one. 

You are correct, the autotest service (which will be put up for review later)
contains the front-end web service portion.  

> Imho for proper
> packaging, at least some changes to the structure need to be made like moving
> the binaries that are supposed to be called by a user /usr/bin and maybe some
> stuff from tools. Or if these scripts are only supposed to be run a the
> service, then they should be moved to /usr/libexec.

> > I can change the default owner back to root:root, and identify the exactly
> > sub-directories that autotest requires write access to if you prefer.  But it
> > may not be possible to have everything root:root under /usr/share/autotest for
> > autotest-client.    
> 
> Yes, please do this. But imho the directories that require write access should
> also be moved below /var. But I somehow doubt, that would be enough. Why is the
> autotest user even necesary? There is no init script that seems to run the
> daemon with this priviliges. Is a user sopposed to su to autotest to use the
> package?    

Upstream has no intention of refactoring the code layout so that it lines up
with a downstream distribution filesystem standards.  While it certainly would
be advantageous for Fedora, and personally more familiar and easier to work
with, it's not something they are willing to adopt at this time.  I'll be happy
to note that in the .spec file as well.

Additionally, I'm not seeing that the strict filesystem guideline adherence is
a blocker to package review.  As far as I can tell, the packaging guidelines
list that as a *should* (not a *must*) requirement [1].

I will update the autotest-client.spec and rebuild with a more conservative
approach to the usr/grp ownership of the /usr/share/autotest directory
structure.  This will likely take a day or more, I will post a comment here
when updates are available.

Many thanks!

[1] https://fedoraproject.org/wiki/Packaging/Guidelines#Filesystem_Layout

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.