[Bug 556433] Review Request: rubygem-eventmachine - Ruby/EventMachine library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=556433

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp

--- Comment #1 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-01-29 13:17:39 EST ---
Some initial comments
- Use "BR: rubygem(rake)" instead of "BR: rubygem-rake" ref:
  https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides
- Don't strip binary and create debuginfo rpm correctly.
- Test fails like:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=1952077
  - 10 tests errors seem to be due to net connection
  -  1 error seems to occur occasionally
- Please mark document files as %doc appropriately
  - At least README file, example/ docs/ directories should be 
    marked as %doc
  - Also I guess tasks/ tests/ web/ directories and Rakefile can be marked
    as %doc
  - it may be preferable to split example/ docs/ tasks/ tests/ web/
    directories and Rakefile into -doc subpackage (I would do so).
- %geminstdir/%gemname.gemspec is not needed. gemspec file is
  installed under specifications directory.
- Use %geminstdir macro in %files as this is defined in the spec file.
- License tag should be "GPLv2 or Ruby"

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.