[Bug 560322] Review Request: urg - Library to access Hokuyo URG laser range finders

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=560322

Tim Niemueller <tim at niemueller.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

--- Comment #2 from Tim Niemueller <tim at niemueller.de> 2010-01-31 12:52:54 EST ---
(In reply to comment #1)
> * Hardcoded /usr/lib in -config scripts in x86_64 package.

Extended norpath patch to remove those. But actually they provided
/usr/lib/(c_)?urg. A patch I submitted has been recently applied to rename
libraries and remove this extra sub-dir of /usr/lib, this is a remnant.

> * /usr/include/urg/findFiles.h depends on boost-devel, but this header is
> optional (currently) and hence the dependency on boost-devel is optional. So,
> this acceptable.

Added boost-devel for devel sub-package to be on the safe side.

> * Only the README mentions the LGPL licensing with a single word. Less than
> ideal (as preferably, the source files also refer to the licensing), but
> acceptable.

Will pass this request to upstream.

> $ rpmlint urg-*.x86_64.rpm
> urg.x86_64: W: spelling-error Summary(en_US) Hokuyo -> Hokum, Hokusai, Hokey
> urg.x86_64: W: name-repeated-in-summary C URG
> urg.x86_64: W: spelling-error %description -l en_US Hokuyo -> Hokum, Hokusai,
> Hokey
> urg-devel.x86_64: W: no-documentation
> 3 packages and 0 specfiles checked; 0 errors, 4 warnings.

All warnings are "ok". The spelling errors are none (company is indeed named
Hokuyo), name repeated in summary intended as explained in original pos, no
documentation for devel package available in tar ball.

> * src.rpm crashes rpmlint from updates-testing ;)

Nothing I can do about it :-)

> * "spectool -g urg-0.8.7-1.fc12.src/urg.spec" only retrieves a HTML page, not
> the tarball.

Fixed, URL to actual file given now, spectool downloads proper file.

> * Please point out the compiler warnings to upstream. Especially the format
> string warnings.    

Will do.

Spec file updated at previous place, new SRPM is at
http://fedorapeople.org/~timn/robotics/urg-0.8.7-2.fc12.src.rpm.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.