[Bug 605373] Review Request: qgis - A user friendly Open Source Geographic Information System

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=605373

--- Comment #6 from Kevin Kofler <kevin at tigcc.ticalc.org> 2010-06-30 18:18:00 EDT ---
Scratch build for F13 also successful:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2284753

A scratch build for Rawhide FAILS due to a Qt-4.7-related issue:
http://koji.fedoraproject.org/koji/getfile?taskID=2284767&name=build.log
cd /builddir/build/BUILD/qgis-1.4.0/src/core && /usr/bin/c++  
-Dqgis_core_EXPORTS -DQT_SVG_LIB -DQT_GUI_LIB -DQT_XML_LIB -DQT_SQL_LIB
-DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_NO_CAST_TO_ASCII -D_LARGE_FILE=1
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE=1 -DSQLITE_ENABLE_RTREE=1
-D_HAVE_PTHREAD_ -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m32 -march=i686 -mtune=atom
-fasynchronous-unwind-tables  -fPIC
-I/builddir/build/BUILD/qgis-1.4.0/src/core/spatialite/headers/spatialite
-I/usr/include/QtSvg -I/usr/include/QtGui -I/usr/include/QtXml
-I/usr/include/QtSql -I/usr/include/QtNetwork -I/usr/include/QtCore
-I/builddir/build/BUILD/qgis-1.4.0 -I/builddir/build/BUILD/qgis-1.4.0/src/core
-I/builddir/build/BUILD/qgis-1.4.0/src/core/composer
-I/builddir/build/BUILD/qgis-1.4.0/src/core/pal
-I/builddir/build/BUILD/qgis-1.4.0/src/core/raster
-I/builddir/build/BUILD/qgis-1.4.0/src/core/renderer
-I/builddir/build/BUILD/qgis-1.4.0/src/core/symbology
-I/builddir/build/BUILD/qgis-1.4.0/src/core/spatialindex/include
-I/builddir/build/BUILD/qgis-1.4.0/src/core/symbology-ng -I/usr/include/gdal  
-DCORE_EXPORT= -DGUI_EXPORT= -DPYTHON_EXPORT= -DANALYSIS_EXPORT= -o
CMakeFiles/qgis_core.dir/qgslabelattributes.cpp.o -c
/builddir/build/BUILD/qgis-1.4.0/src/core/qgslabelattributes.cpp
/builddir/build/BUILD/qgis-1.4.0/src/core/qgshttptransaction.cpp: In
constructor 'QgsHttpTransaction::QgsHttpTransaction(QString, QString, int,
QString, QString, QNetworkProxy::ProxyType, QString, QString)':
/builddir/build/BUILD/qgis-1.4.0/src/core/qgshttptransaction.cpp:51: error:
call of overloaded 'QString(int)' is ambiguous
/usr/include/QtCore/qstring.h:427: note: candidates are: QString::QString(const
QByteArray&)
/usr/include/QtCore/qstring.h:425: note:                 QString::QString(const
char*)
/usr/include/QtCore/qstring.h:726: note:                 QString::QString(const
QString&)
/usr/include/QtCore/qstring.h:106: note:                
QString::QString(QChar)
/usr/include/QtCore/qstring.h:105: note:                 QString::QString(const
QChar*)
/builddir/build/BUILD/qgis-1.4.0/src/core/qgshttptransaction.cpp:51: error:
call of overloaded 'QString(int)' is ambiguous
/usr/include/QtCore/qstring.h:427: note: candidates are: QString::QString(const
QByteArray&)
/usr/include/QtCore/qstring.h:425: note:                 QString::QString(const
char*)
/usr/include/QtCore/qstring.h:726: note:                 QString::QString(const
QString&)
/usr/include/QtCore/qstring.h:106: note:                
QString::QString(QChar)
/usr/include/QtCore/qstring.h:105: note:                 QString::QString(const
QChar*)
make[2]: *** [src/core/CMakeFiles/qgis_core.dir/qgshttptransaction.cpp.o] Error
1

At line 51 of qgis-1.4.0/src/core/qgshttptransaction.cpp, you need to (in a
patch) change the somestring(0) initializations to somestring(), i.e. drop the
0 in the (0).

The reason is that QString((const char *) 0) == QString() == QString::null, but
QString(0) is ambiguous in Qt 4.7 because there's now also a
QString::QString(const QChar *) constructor (whereas it was being interpreted
as QString((const char *) 0) previously). So the redundant 0 should be omitted
and the default constructor used instead.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.