[Bug 577202] Review Request: python-pycha - A library for drawing charts with Python and Cairo

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=577202

--- Comment #2 from Dan Horák <dan at danny.cz> 2010-03-27 06:06:36 EDT ---
formal review is here, see the notes explaining OK* and BAD statuses below:

OK      source files match upstream:
            2fb091e021147bb404bcf019876a61cab28814ef  pycha-0.5.2.tar.gz
OK      package meets naming and versioning guidelines.
OK      specfile is properly named, is cleanly written and uses macros
consistently.
OK      dist tag is present.
BAD     license field matches the actual license.
OK      license is open source-compatible (LGPLv3+). License text included in
package.
OK      latest version is being packaged.
OK*     BuildRequires are proper.
N/A     compiler flags are appropriate.
OK      %clean is present.
OK      package builds in mock (Rawhide/x86_64).
N/A     debuginfo package looks complete.
BAD     rpmlint is silent.
BAD     final provides and requires look sane.
OK      %check is present and all tests pass.
OK      no shared libraries are added to the regular linker search paths.
OK      owns the directories it creates.
OK      doesn't own any directories it shouldn't.
OK      no duplicates in %files.
OK      file permissions are appropriate.
OK      no scriptlets present.
OK      code, not content.
OK      documentation is small, so no -docs subpackage is necessary.
OK      %docs are not necessary for the proper functioning of the package.
OK      no headers.
OK      no pkgconfig files.
OK      no libtool .la droppings.
OK      is a GUI app with a desktop file

- the license is LGPLv3+ because the licensing header contains the "or any
later vesion" part
- is BR: python-devel really required? Only modules with C code should need it.
- rpmlint complains a bit:
chavier.noarch: W: spelling-error Summary(en_US) pycha -> psych, Pynchon,
Psyche
chavier.noarch: W: summary-not-capitalized C a GUI application for exploring
the pycha library
    => I would even shorten it to "Application for exploring the pycha library"
chavier.noarch: W: spelling-error %description -l en_US datasets -> data sets,
data-sets, databases
    => should be fixed
chavier.noarch: W: spelling-error %description -l en_US pycha -> psych,
Pynchon, Psyche
chavier.noarch: W: no-documentation
    => the "pycha" check can be ignored
- pycairo must be set as Requires, it is imported by few files in the pycha
module
- I would not include the tests as %doc, examples should be enough

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.