[Bug 652396] Review Request: rubygem-boxgrinder-core - Core files required by BoxGrinder

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=652396

--- Comment #7 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-11-17 15:07:08 EST ---
Created attachment 461153
  --> https://bugzilla.redhat.com/attachment.cgi?id=461153
mock build log for rawhide

For 0.1.3-1:

Well, the spec file in the srpm and the spec file in
your comment 4 differ, however:

* BR
  - Still your srpm does not build (build log attached).
    At least "BR: rubygem(echoe)" is needed.

! Cleaning up %buildroot at %install
-------------------------------------------
%install
rm -rf %{buildroot}
rm -rf %{_builddir}%{gemdir}
-------------------------------------------
  - Well, on Fedora these lines are no longer needed
    (%buildroot is anyway cleaned at the beginning of %install)

* About output file in %check
> > * Output file on %check
> >   - If %check section produces some extra files, it is preferable
> >     that %check section won't touch %buildroot tree to avoid
> >     unneeded confusion on %files and will touch files under
> >     %_builddir
> >     ( i.e. In this case, it is preferable that gem is once installed
> >       under %_builddir and then copy the whole tree to %buildroot
> >       at %install, then execute %check under %_builddir)
> 
> Right, I didn't know how to deal with that. Should it look like this?
  - Please use "%setup -q -T". Usually we do like
---------------------------------------------
%prep
%setup -q -c -T
mkdir -p .%{gemdir}

gem install -V --local --install-dir .%{gemdir} \
 --force --rdoc %{SOURCE0}

%build

%install
mkdir -p %{buildroot}%{gemdir}
cp -a .%{gemdir}/* %{buildroot}%{gemdir}/
---------------------------------------------

* Dependency
  - I think installed .gemspec (under %{gemdir}/specifications/)
    should have runtime dependency for "hashery".

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.