[Bug 652396] Review Request: rubygem-boxgrinder-core - Core files required by BoxGrinder

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=652396

--- Comment #8 from Marek Goldmann <mgoldman at redhat.com> 2010-11-17 16:36:11 EST ---
(In reply to comment #7)
> Created attachment 461153 [details]
> mock build log for rawhide
> 
> For 0.1.3-1:
> 
> Well, the spec file in the srpm and the spec file in
> your comment 4 differ, however:
> 
> * BR
>   - Still your srpm does not build (build log attached).
>     At least "BR: rubygem(echoe)" is needed.

Added! Sorry for missing that...

> ! Cleaning up %buildroot at %install
> -------------------------------------------
> %install
> rm -rf %{buildroot}
> rm -rf %{_builddir}%{gemdir}
> -------------------------------------------
>   - Well, on Fedora these lines are no longer needed
>     (%buildroot is anyway cleaned at the beginning of %install)

Removed.

> > Right, I didn't know how to deal with that. Should it look like this?
>   - Please use "%setup -q -T". Usually we do like
> ---------------------------------------------
> %prep
> %setup -q -c -T
> mkdir -p .%{gemdir}
> 
> gem install -V --local --install-dir .%{gemdir} \
>  --force --rdoc %{SOURCE0}
> 
> %build
> 
> %install
> mkdir -p %{buildroot}%{gemdir}
> cp -a .%{gemdir}/* %{buildroot}%{gemdir}/
> ---------------------------------------------

Ah, OK, adjusted.

> * Dependency
>   - I think installed .gemspec (under %{gemdir}/specifications/)
>     should have runtime dependency for "hashery".

True, added!

Spec URL:
http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinder-core.spec
SRPM URL:
http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinder-core-0.1.3-3.fc14.src.rpm

Thank you for your help!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.