[Bug 653682] Review Request: jemalloc - General-purpose scalable concurrent malloc(3) implementation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=653682

--- Comment #7 from Ingvar Hagelund <ingvar at linpro.no> 2010-11-18 07:02:09 EST ---
* Martin Gieseking
> sorry for nagging again, but there are still some things to consider
> in your latest spec:

NP :-)


> - please add a short comment above Patch0 telling what the patch does

Fixed.

> - swap the Groups of base and devel package:
>   base package:  System Environment/Libraries
>   devel package: Development/Libraries

Gah! Stupid me. That _was_ my intention. Fixed.

> - Please replace %{_libdir}/libjemalloc.so.1 with 
>   %{_libdir}/libjemalloc.so.* to simplify future soname bumps and to ensure 
>   that all versioned library variants (if there will be any in the future) get
>   packaged.

Fixed.

> - drop %{_includedir}/jemalloc/* in %files devel, as the preceding line 
>   %{_includedir}/jemalloc already adds the directory including all its 
>   contents

Fixed.

> - replace %{_mandir}/man3/jemalloc.3.gz with %{_mandir}/man3/jemalloc.3*
>   since we should not rely on a specific compression format applied by 
>   rpmbuild

Fixed.

Updated srpm and specfile at http://users.linpro.no/ingvar/jemalloc

Ingvar

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.