[Bug 638590] Review Request: freemind - a mind-mapping software written in Java

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=638590

--- Comment #14 from Stanislav Ochotnicky <sochotni at redhat.com> 2010-11-24 11:07:12 EST ---
Now we have:
freemind.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/freemind-0.9.0/LICENSE.MI

sed -i 's/\r//' should do the trick...

freemind.src: W: strange-permission freemind.sh 0755L

that's what I meant with those permissions. Your local freemind.sh is 0755 and
it's included like that in srpm. There should be no executable in srpm, that's
why rpmlint complains.

freemind.src:14: W: mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 1)

Also quite obvious I guess. I suggest to set-up your editor :-)

Dangling symlinks can't be avoided, no problem there.

Plus there is the issue of:
/usr/bin/build-classpath: error: Could not find jibx/run-1.2.2 Java extension
for this JVM
/usr/bin/build-classpath: error: Some specified jars were not found

This is caused by you missing jibx in Requires and using exact versions in
freemind.sh BASE_JARS. Also when doing build-jar-repository. Instead of:
build-jar-repository -p -s jibx bcel commons-logging log4j xpp3 jibx/bind-1.2.2
jibx/extras-1.2.2 jibx/run-1.2.2 jaxme/jaxmejs

do:
build-jar-repository -p -s jibx bcel commons-logging log4j xpp3 jibx/bind
jibx/extras jibx/run jaxme/jaxmejs

One small (cosmetic) detail: It's best to keep line width under 80 chars, so
that one long build-jar-repository can be done like this:
build-jar-repository -p -s . batik/batik-awt-util batik/batik-bridge \
                             batik/batik-css batik/batik-dom
batik/batik-extension \
....
....

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.