[Bug 639991] Review Request: rubygem-rb-inotify - A Ruby wrapper for Linux's inotify, using FFI

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=639991

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?

--- Comment #2 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-10-10 14:18:15 EDT ---
Some notes:

* Unused macro
  - Please remove unused macro defined in the spec file

* Explicit dependency
  - ">= 0.5.0" part on "Requires: rubygem(ffi)" is not needed
    because rubygem-ffi packages on currently supported branches
    on Fedora all satisfy this version dependency.

* %files
  - The directory %geminstdir itself is not owned by any
    packages.

  - The following files should also be %doc
-------------------------------------------------------
%{geminstdir}/Rakefile
%{geminstdir}/rb-inotify.gemspec
-------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.