[Bug 680657] Review Request: mpdas - An MPD audioscrobbling client
bugzilla at redhat.com
bugzilla at redhat.com
Sat Apr 9 12:03:43 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=680657
--- Comment #7 from Lakshmi Narasimhan <lakshminaras2002 at gmail.com> 2011-04-09 08:03:41 EDT ---
Hi Ankur,
I checked the spec. Looks fine.
Two issues.
1) There is a tab/space issue which can be fixed.
2) rpmlint warns about very small size of the debuginfo package. I found that
the RPM_OPT_FLAGS are not being honoured when the build is happening and hence
the small size. I built the package using make command, passing the
RPM_OPT_FLAGS and the debuginfo package is around 124-130 KB. rpmlint doesn't
complain about this package.
I made this change to the spec file in %build section
export CXXFLAGS=$RPM_OPT_FLAGS && make CONFIG=%{_sysconfdir}
but not sure whether this is the right way to make the build accept the
CXXFLAGS.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list