[Bug 700335] Review Request: ant-antlr3 - Antlr3 task for Ant

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700335

--- Comment #4 from Karel Klíč <kklic at redhat.com> 2011-04-28 09:33:27 EDT ---
Spec URL: http://kklic.fedorapeople.org/ant-antlr3.spec
SRPM URL: http://kklic.fedorapeople.org/ant-antlr3-20110110-2.fc14.src.rpm

* Thu Apr 28 2011 Karel Klíč <kklic at redhat.com> - 20110110-2
- Added /etc/ant.d integration
- Require jpackage-utils by -javadoc package (needed for directory)
- Remove bundled jar in %%prep

> 1. javadoc requires on jpackage-utils
Fixed.

> 2. source url...is it going to be fixed for fedora rpms?
RPM developers decided to fix it in upstream only. I'll revisit the issue every
time the package is updated (inevitably, as the upstream file needs to be
repackaged until the bug is fixed).
I think this is not a blocker.

> 3. inclusion license file in zipball and versioned zipball releases (upstream)
I'm going to write an email to the upstream developer right now and ask him for
this. This should not block the review process.

> 4. remove bundled jar for the sake of consistency :-)
Done

> 5. include already mentioned ant.d file
Done

Thank you for the review!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.