[Bug 700335] Review Request: ant-antlr3 - Antlr3 task for Ant

bugzilla at redhat.com bugzilla at redhat.com
Thu Apr 28 14:01:36 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700335

--- Comment #5 from Stanislav Ochotnicky <sochotni at redhat.com> 2011-04-28 10:01:35 EDT ---
I am almost sure this is wrong:
cat > $RPM_BUILD_ROOT%{_sysconfdir}/ant.d/ant-antlr3 << EOF
ant-antlr3 antlr3
EOF


Shouldn't it be?:
cat > $RPM_BUILD_ROOT%{_sysconfdir}/ant.d/ant-antlr3 << EOF
ant/ant-antlr3 antlr3
EOF

Other than package seems good now, but I'd advise you to actually use it when
building something (nudge nudge, wink wink - stanse) to see that it actually
works.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list