[Bug 689039] Review Request: csdp - C library for SemiDefinite Programming

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=689039

Hedayat Vatankhah <hedayatv at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hedayatv at gmail.com
         AssignedTo|nobody at fedoraproject.org    |hedayatv at gmail.com
               Flag|                            |fedora-review?

--- Comment #1 from Hedayat Vatankhah <hedayatv at gmail.com> 2011-04-29 19:20:55 EDT ---
Hi!
This is my review for your package:

MUST Items:
------------

RpmLint Output:
% rpmlint csdp-6.1.1-1.fc14.src.rpm
csdp.src: W: spelling-error %description -l en_US semidefinite -> semi
definite, semi-definite, definiteness
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

% rpmlint noarch/csdp-octave-6.1.1-1.fc14.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

% rpmlint csdp-*
csdp.x86_64: W: spelling-error %description -l en_US semidefinite -> semi
definite, semi-definite, definiteness
csdp.x86_64: W: shared-lib-calls-exit /usr/lib64/libsdp.so.6.1.1
exit at GLIBC_2.2.5
4 packages and 0 specfiles checked; 0 errors, 2 warnings.
---------------------------------------------------------------------------

Built successfully in Koji.
http://koji.fedoraproject.org/koji/taskinfo?taskID=3036616

Passes other MUST and SHOULD items, including Packaging Guidelines.

Some notes before accepting the package:
- semidefinite looks like to be an acceptable word, but if semi-definite is a
better replacement please replace it
- defattr can be removed from the %files sections as recently added to the
Packaging Guidelines
- Where does Csdp.INDEX file in src.rpm come from?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.