[Bug 700962] Review Request: pydf - Fully colorized df clone written in python

Sat Apr 30 14:13:52 UTC 2011

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=700962

Adam Huffman <bloch at verdurin.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bloch at verdurin.com

--- Comment #1 from Adam Huffman <bloch at verdurin.com> 2011-04-30 10:13:51 EDT ---
Here's the output of a run through Tim Lauridsen's review tool:

Package Review
==============

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

[x] : MUST - Package successfully compiles and builds into binary rpms on at
least one supported architecture.
[x] : MUST - %config files are marked noreplace or the reason is justified.
[x] : MUST - Package does not contain any libtool archives (.la)
[x] : MUST - Package use %makeinstall only when make install DESTDIR=...
doesn't work.
[x] : MUST - Package is named according to the Package Naming Guidelines.
[x] : MUST - Sources used to build the package matches the upstream source, as
provided in the spec URL.
        MD5SUM this package     : 71778fd7b6668ac157ea06a8867f2d20
        MD5SUM upstream package : 71778fd7b6668ac157ea06a8867f2d20
[x] : MUST - Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-] : MUST - Package contains a properly installed %{name}.desktop using
desktop-file-install file if it is a GUI application.
[-] : MUST - Fully versioned dependency in subpackages, if present.
[-] : MUST - Header files in -devel subpackage, if present.
[-] : MUST - ldconfig called in %post and %postun if required.
[-] : MUST - License file installed when any subpackage combination is
installed.
[-] : MUST - The spec file handles locales properly.
[-] : MUST - Development .so files in -devel subpackage, if present.
[-] : MUST - Static libraries in -static subpackage, if present.
[!] : MUST - Spec file lacks Packager, Vendor, PreReq tags.
        Found : Packager: Adam Huffman <bloch at verdurin.com>

[!] : MUST - Rpmlint output is silent.

        rpmlint pydf-9-1.src.rpm

================================================================================
        pydf.src: W: spelling-error Summary(en_US) df -> sf, ff, dd
        pydf.src: W: spelling-error %description -l en_US df -> sf, ff, dd
        pydf.src: W: spelling-error %description -l en_US customizable ->
customization, customize, customable
        pydf.src:11: W: hardcoded-path-in-buildroot-tag
/tmp/%{name}-%{version}-root
        pydf.src:6: W: mixed-use-of-spaces-and-tabs (spaces: line 6, tab: line
1)
        1 packages and 0 specfiles checked; 0 errors, 5 warnings.

================================================================================

        rpmlint pydf-9-1.noarch.rpm

================================================================================
        pydf.noarch: W: spelling-error Summary(en_US) df -> sf, ff, dd
        pydf.noarch: W: spelling-error %description -l en_US df -> sf, ff, dd
        pydf.noarch: W: spelling-error %description -l en_US customizable ->
customization, customize, customable
        1 packages and 0 specfiles checked; 0 errors, 3 warnings.

================================================================================

[ ] : MUST - Package is licensed with an open-source compatible license and
meets other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ] : MUST - %build honors applicable compiler flags or justifies otherwise.
[ ] : MUST - All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[ ] : MUST - Package contains no bundled libraries.
[ ] : MUST - Changelog in prescribed format.
[ ] : MUST - Sources contain only permissible code or content.
[ ] : MUST - Macros in Summary, %description expandable at SRPM build time.
[ ] : MUST - Package requires other packages for directories it uses.
[ ] : MUST - Package uses nothing in %doc for runtime.
[ ] : MUST - Package is not known to require ExcludeArch.
[ ] : MUST - Permissions on files are set properly.
[ ] : MUST - Package does not contain duplicates in %files.
[ ] : MUST - Large documentation files are in a -doc subpackage, if required.
[ ] : MUST - If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[ ] : MUST - License field in the package spec file matches the actual license.
[ ] : MUST - Package consistently uses macros. instead of hard-coded directory
names.
[ ] : MUST - Package meets the Packaging Guidelines.
[ ] : MUST - No %config files under /usr.
[ ] : MUST - Package does not generates any conflict.
[ ] : MUST - Package does not contains kernel modules.
[ ] : MUST - Package contains no static executables.
[ ] : MUST - Package obeys FHS, except libexecdir and /usr/target.
[ ] : MUST - Package must own all directories that it creates.
[ ] : MUST - Package does not own files or directories owned by other packages.
[ ] : MUST - Package installs properly.
[ ] : MUST - Rpath absent or only used for internal libs.
[ ] : MUST - Package is not relocatable.
[ ] : MUST - Requires correct, justified where necessary.
[ ] : MUST - Spec file is legible and written in American English.
[ ] : MUST - Package contains a SysV-style init script if in need of one.
[ ] : MUST - File names are valid UTF-8.
[ ] : MUST - Useful -debuginfo package or justification otherwise.
[x] : SHOULD - Reviewer should test that the package builds in mock.
[x] : SHOULD - SourceX is a working URL.
[-] : SHOULD - Uses parallel make.
[-] : SHOULD - The placement of pkgconfig(.pc) files are correct.
[!] : SHOULD - Dist tag is present.
[!] : SHOULD - SourceX / PatchY prefixed with %{name}.
        Source: 
http://kassiopeia.juls.savba.sk/~garabik/software/pydf/pydf_9.tar.gz
(pydf_9.tar.gz)

[!] : SHOULD - Spec use %global instead of %define.
        %define date %(echo `LC_ALL="C" date +"%a %b %d %Y"`)

[ ] : SHOULD - If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
[ ] : SHOULD - No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[ ] : SHOULD - Final provides and requires are sane (rpm -q --provides and rpm
-q --requires).
[ ] : SHOULD - Package functions as described.
[ ] : SHOULD - Latest version is packaged.
[ ] : SHOULD - Package does not include license text files separate from
upstream.
[ ] : SHOULD - Man pages included for all executables.
[ ] : SHOULD - Patches link to upstream bugs/comments/lists or are otherwise
justified.
[ ] : SHOULD - Scriptlets must be sane, if used.
[ ] : SHOULD - Description and summary sections in the package spec file
contains translations for supported Non-English languages, if available.
[ ] : SHOULD - Package should compile and build into binary rpms on all
supported architectures.
[ ] : SHOULD - %check is present and all tests pass.
[ ] : SHOULD - Packages should try to preserve timestamps of original installed
files.

Issues:
[!] : MUST - Spec file lacks Packager, Vendor, PreReq tags.
        Found : Packager: Adam Huffman <bloch at verdurin.com>
- this can be ignored

[!] : MUST - Rpmlint output is silent.

        rpmlint pydf-9-1.src.rpm

================================================================================
        pydf.src: W: spelling-error Summary(en_US) df -> sf, ff, dd
        pydf.src: W: spelling-error %description -l en_US df -> sf, ff, dd
        pydf.src: W: spelling-error %description -l en_US customizable ->
customization, customize, customable
        pydf.src:11: W: hardcoded-path-in-buildroot-tag
/tmp/%{name}-%{version}-root
        pydf.src:6: W: mixed-use-of-spaces-and-tabs (spaces: line 6, tab: line
1)
        1 packages and 0 specfiles checked; 0 errors, 5 warnings.

================================================================================

        rpmlint pydf-9-1.noarch.rpm

================================================================================
        pydf.noarch: W: spelling-error Summary(en_US) df -> sf, ff, dd
        pydf.noarch: W: spelling-error %description -l en_US df -> sf, ff, dd
        pydf.noarch: W: spelling-error %description -l en_US customizable ->
customization, customize, customable
        1 packages and 0 specfiles checked; 0 errors, 3 warnings.

================================================================================

You should also consider using macros consistently, rather than mixing styles
as you are doing at present i.e. %{buildroot} rather than $RPM_BUILD_ROOT

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.