[Bug 663925] Review Request: autoconf-archive - The Autoconf Macro Archive

Sat Apr 30 13:48:17 UTC 2011

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=663925

--- Comment #5 from Adam Huffman <bloch at verdurin.com> 2011-04-30 09:48:15 EDT ---

Package Review
==============

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

[x] : MUST - Package successfully compiles and builds into binary rpms on at
least one supported architecture.
[x] : MUST - Package does not contain any libtool archives (.la)
[x] : MUST - Package use %makeinstall only when make install DESTDIR=...
doesn't work.
[x] : MUST - Package is named according to the Package Naming Guidelines.
[x] : MUST - Rpmlint output is silent.

        rpmlint autoconf-archive-2011.03.17-0.fc16.src.rpm

================================================================================
        1 packages and 0 specfiles checked; 0 errors, 0 warnings.

================================================================================

        rpmlint autoconf-archive-2011.03.17-0.fc16.noarch.rpm

================================================================================
        1 packages and 0 specfiles checked; 0 errors, 0 warnings.

================================================================================

[x] : MUST - Sources used to build the package matches the upstream source, as
provided in the spec URL.
        MD5SUM this package     : 95db13b789f02f449d11cb822b07c376
        MD5SUM upstream package : 95db13b789f02f449d11cb822b07c376
[x] : MUST - Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-] : MUST - %config files are marked noreplace or the reason is justified.
[-] : MUST - Package contains a properly installed %{name}.desktop using
desktop-file-install file if it is a GUI application.
[-] : MUST - Fully versioned dependency in subpackages, if present.
[-] : MUST - Header files in -devel subpackage, if present.
[-] : MUST - ldconfig called in %post and %postun if required.
[-] : MUST - License file installed when any subpackage combination is
installed.
[-] : MUST - The spec file handles locales properly.
[-] : MUST - No %config files under /usr.
[-] : MUST - Development .so files in -devel subpackage, if present.
[-] : MUST - Static libraries in -static subpackage, if present.
[!] : MUST - Spec file lacks Packager, Vendor, PreReq tags.
        Found : Packager: Adam Huffman <bloch at verdurin.com>

[x] : MUST - Package is licensed with an open-source compatible license and
meets other legal requirements as defined in the legal section of Packaging
Guidelines.
[x] : MUST - %build honors applicable compiler flags or justifies otherwise.
[x] : MUST - All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x] : MUST - Package contains no bundled libraries.
[x] : MUST - Changelog in prescribed format.
[x] : MUST - Sources contain only permissible code or content.
[x] : MUST - Macros in Summary, %description expandable at SRPM build time.
[-] : MUST - Package requires other packages for directories it uses.
[x] : MUST - Package uses nothing in %doc for runtime.
[x] : MUST - Package is not known to require ExcludeArch.
[x] : MUST - Permissions on files are set properly.
[x] : MUST - Package does not contain duplicates in %files.
[-] : MUST - Large documentation files are in a -doc subpackage, if required.
[x] : MUST - If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[!] : MUST - License field in the package spec file matches the actual license.
[x] : MUST - Package consistently uses macros. instead of hard-coded directory
names.
[x] : MUST - Package meets the Packaging Guidelines.
[x] : MUST - Package does not generates any conflict.
[x] : MUST - Package does not contains kernel modules.
[x] : MUST - Package contains no static executables.
[x] : MUST - Package obeys FHS, except libexecdir and /usr/target.
[-] : MUST - Package must own all directories that it creates.
[x] : MUST - Package does not own files or directories owned by other packages.
[!] : MUST - Package installs properly.
[x] : MUST - Rpath absent or only used for internal libs.
[?] : MUST - Package is not relocatable.
[x] : MUST - Requires correct, justified where necessary.
[x] : MUST - Spec file is legible and written in American English.
[-] : MUST - Package contains a SysV-style init script if in need of one.
[x] : MUST - File names are valid UTF-8.
[-] : MUST - Useful -debuginfo package or justification otherwise.
[x] : SHOULD - Reviewer should test that the package builds in mock.
[x] : SHOULD - Dist tag is present.
[x] : SHOULD - SourceX is a working URL.
[x] : SHOULD - Spec use %global instead of %define.
[-] : SHOULD - Uses parallel make.
[-] : SHOULD - The placement of pkgconfig(.pc) files are correct.
[!] : SHOULD - SourceX / PatchY prefixed with %{name}.
        Source0:
ftp://ftp.gnu.org/gnu/autoconf-archive/autoconf-archive-%{version}.tar.xz
(autoconf-archive-%{version}.tar.xz)

[-] : SHOULD - If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
[x] : SHOULD - No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[?] : SHOULD - Final provides and requires are sane (rpm -q --provides and rpm
-q --requires).
[x] : SHOULD - Package functions as described.
[!] : SHOULD - Latest version is packaged.
[x] : SHOULD - Package does not include license text files separate from
upstream.
[-] : SHOULD - Man pages included for all executables.
[-] : SHOULD - Patches link to upstream bugs/comments/lists or are otherwise
justified.
[!] : SHOULD - Scriptlets must be sane, if used.
[-] : SHOULD - Description and summary sections in the package spec file
contains translations for supported Non-English languages, if available.
[x] : SHOULD - Package should compile and build into binary rpms on all
supported architectures.
[-] : SHOULD - %check is present and all tests pass.
[?] : SHOULD - Packages should try to preserve timestamps of original installed
files.

Issues:
[!] : MUST - Spec file lacks Packager, Vendor, PreReq tags.
this can be ignored, I think

[!] : MUST - License field in the package spec file matches the actual license.
Does COPYING.EXCEPTION need to be included?
Some of the files in build-aux imply GPLv3+

[!] : MUST - Package installs properly.
Message when installing on F14:

install-info: Is a directory for /usr/share/info

Please take a look at the issues listed here.  Otherwise, it seems fine.

In case you have some spare time I'd greatly appreciate someone looking at
https://bugzilla.redhat.com/show_bug.cgi?id=627936

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.