[Bug 701031] Review Request: zeitgeist-datahub - The zeitgeist engine data logger
bugzilla at redhat.com
bugzilla at redhat.com
Sat Apr 30 18:58:01 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=701031
--- Comment #4 from Mario Blättermann <mariobl at freenet.de> 2011-04-30 14:58:00 EDT ---
(In reply to comment #3)
> I have dropped the empty ChangeLog file, replace the https link with the http
> one and put the period at the end of the description. I believe the rest if OK.
No, unfortunately not:
(In reply to comment #1)
> Please use macros consistently and as many as possible, as follows:
>
> URL: https://launchpad.net/%{name}
>...
>
> %{_bindir}/%{name}
> %{_mandir}/man1/%{name}.*
> %{_sysconfdir}/xdg/autostart/%{name}.desktop
>
> ...
> You have to drop glib2-devel and gettext from BuildRequires. They are recursive
> dependencies of gtk2-devel and intltool, respectively.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list