[Bug 225255] Merge Review: arptables_jf

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225255

Michal Sekletar <msekleta at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

--- Comment #9 from Michal Sekletar <msekleta at redhat.com> 2011-08-16 03:09:34 EDT ---
Checked git commit
8b1d1dbab8f89c2301349f176aa57cd049cbbdf5 
NO  source files match upstream 
  - there is no upstream for arptables_jf package
YES package meets naming and versioning guidelines
  - package name contains underscore but package arptables_jf is on the
    list of packages which don't have to obey this particular guideline
    https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Separators
YES spec file is properly named, is cleanly written and uses macros
consistently
YES dist tag is present
YES clean section and buildroot present
YES licence field matches the actual license
NO  license text included in package
  - no text file with license is not included in source tarball, it should be 
    present
YES latest version is being packaged
NO  BuildRequiers are proper (Perl?)
  - I think perl is not needed to properly build the package
YES compiler flags are appropriate
YES package builds in mock
YES debuginfo package looks complete
NO  rpmlint is silent
  - $ rpmlint arptables_jf.spec
    arptables_jf.spec: W: invalid-url Source0: arptables_jf-0.0.8.tbz
    0 packages and 1 specfiles checked; 0 errors, 1 warnings.

    - warning about invalid-url is ok since there's no upstream, thus there's
      no url pointing to upstream's remote source code tarball

  - $ rpmlint arptables_jf-0.0.8-22.fc17.src.rpm
    arptables_jf.src: W: spelling-error Summary(en_US) Userspace -> User space,
User-space, Users pace
    arptables_jf.src: W: spelling-error Summary(en_US) arptables -> portables,
stables, tables
    arptables_jf.src: W: spelling-error %description -l en_US arptables ->
portables, stables, tables
    arptables_jf.src: W: spelling-error %description -l en_US jf -> hf, jg, j
    arptables_jf.src: W: spelling-error %description -l en_US arpfilter ->
filterer
    arptables_jf.src: W: spelling-error %description -l en_US firewalling ->
fire walling, fire-walling, firewall
    arptables_jf.src: W: spelling-error %description -l en_US arp -> rap, tarp,
carp
    arptables_jf.src: W: no-url-tag
    arptables_jf.src: W: invalid-url Source0: arptables_jf-0.0.8.tbz
    1 packages and 0 specfiles checked; 0 errors, 9 warnings.

    - spelling errors could be safely ignored
    - no url tag and invalid source warnings could be ignored because there
      is no upstream

  - $ rpmlint arptables_jf-0.0.8-22.fc17.x86_64.rpm
    arptables_jf.x86_64: W: spelling-error Summary(en_US) Userspace -> User
space, User-space, Users pace
    arptables_jf.x86_64: W: spelling-error %description -l en_US jf -> hf, jg,
j
    arptables_jf.x86_64: W: spelling-error %description -l en_US arpfilter ->
filterer
    arptables_jf.x86_64: W: spelling-error %description -l en_US firewalling ->
fire walling, fire-walling, firewall
    arptables_jf.x86_64: W: spelling-error %description -l en_US arp -> rap,
tarp, carp
    arptables_jf.x86_64: W: incoherent-version-in-changelog 0:0.0.8-22
['0.0.8-22.fc17', '0.0.8-22']
    arptables_jf.x86_64: W: no-url-tag
    arptables_jf.x86_64: W: missing-lsb-keyword Default-Stop in
/etc/rc.d/init.d/arptables_jf
    arptables_jf.x86_64: E: incoherent-subsys /etc/rc.d/init.d/arptables_jf
arptables
    arptables_jf.x86_64: E: incoherent-subsys /etc/rc.d/init.d/arptables_jf
arptables
    arptables_jf.x86_64: E: incoherent-subsys /etc/rc.d/init.d/arptables_jf
arptables
    1 packages and 0 specfiles checked; 3 errors, 8 warnings.

    - spelling errors could be ignored
    - incoherent version in changelog warning is caused by use of dist tag and 
      could be safely ignored
    - incoherent-subsys, changes due to satisfying rpmlint could break user's 
      scripts, thus warning is ignored
    - spelling errors could be ignored

  - $ rpmlint arptables_jf-debuginfo-0.0.8-22.fc17.x86_64.rpm
    arptables_jf-debuginfo.x86_64: W: spelling-error Summary(en_US) arptables
-> portables, stables, tables
    arptables_jf-debuginfo.x86_64: W: spelling-error Summary(en_US) jf -> hf,
jg, j
    arptables_jf-debuginfo.x86_64: W: spelling-error %description -l en_US
arptables -> portables, stables, tables
    arptables_jf-debuginfo.x86_64: W: spelling-error %description -l en_US jf
-> hf, jg, j
    arptables_jf-debuginfo.x86_64: W: no-url-tag
    1 packages and 0 specfiles checked; 0 errors, 5 warnings.

    - spelling errors could be ignored
    - no-url-tag warning is ok because there's no upstream

YES final provides and requires look sane
N/A %check is present and all tests pass
YES no shared libraries are added to the regular linker search paths
N/A owns the directories it creates
  - package content is copied into already existing directories
YES doesn't own any directories it shouldn't
YES no duplicates in %files
YES scriptlets looks sane
YES code, not content
N/A large documentation files must go in a -doc subpackage.
YES %docs are not necessary for the proper functioning of the package.
YES no headers.
YES no pkgconfig files.
YES no libtool .la droppings.
YES not a GUI app.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.