[Bug 677496] Review Request: nbc - Next Byte Codes (NBC) and Not Exactly C (NXC)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=677496

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de

--- Comment #1 from Martin Gieseking <martin.gieseking at uos.de> 2011-02-27 17:15:22 EST ---
Hi Rich,

here are some initial comments:

- I suggest to choose a more descriptive Summary, e.g. something like
  "Simple language to program LEGO's NXT programmable brick"

- Don't mix spaces and tabs for indentation. Just use one of them.

- please preserve the timestamps of all %doc files and the manpage. You can   
  accomplish this by adding the following to the %prep section:
    cd doc
    for f in Readme Changelog; do
      dos2unix -n $f $f.tmp && \
      touch -r $f $f.tmp && \
      mv $f.tmp $f
    done

  Drop the dos2unix lines from %build.
  Also, remove the call of gzip from the Makefile as rpmbuild compresses the 
  manpage automatically, and add switch -p to "install".

- Add %{_smp_mflags} to "make" in order to enable parallel builds.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.