[Bug 637213] Review Request: yubikey-val - The YubiKey Validation Server

bugzilla at redhat.com bugzilla at redhat.com
Sat Jan 8 01:52:19 UTC 2011

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


Ricky Zhou <rzhou at redhat.com> changed:

           What    |Removed                     |Added
         AssignedTo|nobody at fedoraproject.org    |rzhou at redhat.com
               Flag|                            |fedora-review+

--- Comment #3 from Ricky Zhou <rzhou at redhat.com> 2011-01-07 20:52:17 EST ---
OK - rpmlint clean

yubikey-val.src: W: invalid-url Source0:
http://yubikey-val-server-php.googlecode.com/files/yubikey-val-2.7.tgz HTTP
Error 404: Not Found
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

yubikey-val.noarch: E: non-readable /etc/ykval/ykval-config.php 0640L
yubikey-val.noarch: W: no-manual-page-for-binary ykval-export
yubikey-val.noarch: W: no-manual-page-for-binary ykval-queue
yubikey-val.noarch: W: no-manual-page-for-binary ykval-import
yubikey-val.noarch: W: no-manual-page-for-binary ykval-checksum-clients
1 packages and 0 specfiles checked; 1 errors, 4 warnings.

Non-readable error and google code warning are false positives.

OK - package meets naming guidelines
OK - spec file name matches base package name
OK - meets packaging guidelines
OK - meets licensing guidelines
OK - license field matches
OK - spec in American English
OK - spec is legible
OK - spec sources match upstream
OK - builds in mock
OK - no bundled libs
OK - owns its directories, does not own files owned by other packages
OK - does not list a file more than once
OK - permissions are OK
OK - consistently uses macros
OK - contains code or permissible content
OK - files in %doc do not affect runtime
OK - filenames valid UTF-8

SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.


Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

More information about the package-review mailing list