[Bug 670090] Review Request: bicon - Bidirectional Console

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=670090

Daiki Ueno <dueno at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

--- Comment #5 from Daiki Ueno <dueno at redhat.com> 2011-01-18 02:03:48 EST ---
(In reply to comment #4)

> >  bicon.x86_64: E: non-readable /usr/share/doc/bicon-0.2.0/README 0600L
> >  bicon.x86_64: E: non-readable /usr/share/doc/bicon-0.2.0/COPYING 0600L
> >  bicon.x86_64: E: non-readable /usr/share/doc/bicon-0.2.0/AUTHORS 0600L
> 
> I didn't get the same error with my scratch build but I added chmod at the
> moment.

Sorry, my bad.  That was because I used "fakeroot rpmbuild --rebuild" to check
the SRPM on F-14.  Please feel free to revert the change when you import the
package into the git.

BTW, according to COPYING, bicon/pty_spawn.c is covered by the Python license. 
The License tag should be fixed:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.