[Bug 652414] Review Request: rubygem-boxgrinder-build-sftp-delivery-plugin - BoxGrinder plugin delivering appliances to SFTP servers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=652414

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

--- Comment #10 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2011-01-21 13:17:41 EST ---
Well, nothing which must be fixed I see.

* source clean, match with the upstream
* spec file clean
* builds on koji
* rebuilt rpms can be installed
* basic operation (for gem related pkg) works

! One misc
  - "rm -rf %{buildroot}" at the beginning of %install is no
    longer needed.

------------------------------------------------------------------
    This package (rubygem-boxgrinder-build-sftp-delivery-plugin)
    is APPROVED by mtasaka
------------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.