[Bug 668090] Review Request: rubygem-railties - Rails internals: application bootup, plugins, generators, and rake tasks.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668090

--- Comment #8 from Minnikhanov <minnikhanov at gmail.com> 2011-01-27 15:13:46 EST ---
Spec URL: http://dl.dropbox.com/u/14118661/rubygem-railties.spec
SRPM URL:
http://dl.dropbox.com/u/14118661/rubygem-railties-3.0.3-5.fc14.src.rpm 

koji scratch build: green
http://koji.fedoraproject.org/koji/taskinfo?taskID=2746333 
TEST DON'T PASS. 
Packages built.


(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > (In reply to comment #4)
> To get around the failed tests you will need the following which I've added to
> all the other rails 3 rpms:
> 
> --- test/abstract_unit.rb.orig  2011-01-26 22:08:06.697352089 -0500
> +++ test/abstract_unit.rb       2011-01-26 22:53:04.463351981 -0500
> @@ -1,4 +1,4 @@
> -require File.expand_path("../../../load_paths", __FILE__)
> +require 'rubygems'
> 
>  require 'stringio'
>  require 'test/unit'

+ Fixed.

> 
> This will only get you to another set of errors. Looking into those its
> apparent that the railties test suite is dependent on the rails gem itself to
> work, introducing a circular dependency, thus cannot be included in the rpm. I
> verified the functionality though through use via the rubygem-rails package.
> 
> With this you can remove (or at least comment out) quite a few things relating
> to the test suite. Also remove the bits deleting the .empty_directory files.
> After that I'll approve.

I saw test suite and look only circular dependency to rails's gems. I am not
ready break these loops.

May I offer:
1. Remove all test suite.
2. Build clear gem rpm.
3. Prepare test suite rpm. 
3. After build all rpms, build test suite rpm and run it.

Source 'railties' found in the same git-repo where found 'rails' and other
basis of rails.
Rails's developer tests all together.
My opinion we must go the same way - 
1 - Build all, 2 - Install all, 3 - Test all after all.

PS. Packages that can test separately, build with test suite. For another
packages make separate post-build/installation test-suite rpm.
railties-test-<ver>....rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.