[Bug 722914] Review Request: volumeicon - Lightweight volume control for the system tray

bugzilla at redhat.com bugzilla at redhat.com
Thu Jul 21 14:23:04 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=722914

--- Comment #11 from Jussi Lehtola <jussi.lehtola at iki.fi> 2011-07-21 10:23:03 EDT ---
(In reply to comment #5)
> (In reply to comment #2)
> > - As a courtesy to people reading your spec files, please don't use macros in
> > the URL if they're not absolutely necessary.
> 
> Why not? we have spectool...

Copy'n'paste doesn't work that well with macros. Spectool is great for getting
the sources, but it doesn't give project URLs. As far as I see it, the
alternative is getting the sources, building the RPM and running
 $ rpm -qpi package.rpm
to see the expanded URL...

Anyway, even if the project name were ridiculously long, I doubt that you'd
spend many characters spelling it out explicitly, compared to using the %{name}
macro. It's a huge help, e.g. when you browse the review queue or look at spec
files at pkgs.fedoraproject.org.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list