[Bug 682545] Review Request: nutrika - Nutrient content calculator and intake analyzer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=682545

Ralf Corsepius <rc040203 at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203 at freenet.de

--- Comment #2 from Ralf Corsepius <rc040203 at freenet.de> 2011-03-06 12:27:51 EST ---
(In reply to comment #1)
> Only few comments:
> 
> You're using RPM_BUILD_ROOT (variable style) and ?_smp_mflags (macro style) 
> Mixing the two styles, while valid, is bad from a QA and usability point of
> view, and should not be done in Fedora packages.
You are confused:

The only variables which must not be mixed within a spec file is 
$RPM_BUILD_ROOT and %buildroot.

There is nothing wrong with mixing %{?_smp_mflags} and $RPM_BUILD_ROOT.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.