[Bug 635511] Review Request: assimp - Library to import various 3D model formats into applications

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=635511

--- Comment #28 from Tom "spot" Callaway <tcallawa at redhat.com> 2011-03-22 13:25:11 EDT ---
I'm working with the irrlicht upstream to merge the fast_atof improvements that
assimp needs. They're on board in principle, but they didn't like some of the
function naming (the original patch changed the existing function strtol10 from
returning a signed int to an unsigned int), so I reworked the code so that
strtol10 returns a signed int, and there are new "u" functions (e.g. strtoul10)
that return the unsigned ints.

I had to patch assimp for the new names, here's that patch:
http://spot.fedorapeople.org/assimp-2.0.863-new-fastatof-typenames.patch

For reference, the irrlicht patch is here:
http://spot.fedorapeople.org/irrlicht-1.7.2-fastatof-improvements-typefixes.patch

I've done test compiles with both patches in play, and things look good. Now,
we just need more feedback from irrlicht upstream as to whether they will take
this change or not. I'm happy to carry the irrlicht patch in the short term. It
would probably be a good idea to let assimp know about this, and get their
feedback on the name changes.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.