[Bug 702892] Review Request: python-modjkapi - API for modjk management
bugzilla at redhat.com
bugzilla at redhat.com
Wed May 11 15:55:04 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702892
--- Comment #2 from Kevin Fenzi <kevin at scrye.com> 2011-05-11 11:55:02 EDT ---
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPLv3+)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
72a6c9e090ca7ef20366a22235c658f7 modjkapi-0.1.2.28.tar.gz
72a6c9e090ca7ef20366a22235c658f7 modjkapi-0.1.2.28.tar.gz.orig
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output.
OK - final provides and requires are sane.
SHOULD Items:
OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have sane scriptlets.
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin
Issues:
1. The /usr/bin/bleeder binary seems oddly named. Is there some history there?
2. rpmlint says:
python-modjkapi.noarch: W: no-manual-page-for-binary bleeder
python-modjkapi.src: W: strange-permission modjkapi-0.1.2.28.tar.gz 0660L
Might set the perms to 644? Or might be something odd on my end.
The man page warning you can ignore, but of course it's nice to add
a man page too. ;)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list