[Bug 702892] Review Request: python-modjkapi - API for modjk management

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=702892

--- Comment #3 from Tim Bielawa <tbielawa at redhat.com> 2011-05-11 15:25:06 EDT ---
(In reply to comment #2)

Spec URL remains the same:
http://people.redhat.com/~tbielawa/modjkapi/python-modjkapi.spec

SRPM changed to:
http://people.redhat.com/~tbielawa/modjkapi/releases/modjkapi-latest/python-modjkapi-0.1.2.28-7.fc14.src.rpm


> Issues: 
> 
> 1. The /usr/bin/bleeder binary seems oddly named. Is there some history there?

Heh, when used in context the name made more sense. It 'bleeds off connections'
from a node in a load balancer pool, before removing the node -- but it also
reenables nodes.

I've renamed it to something more descriptive: 'jk-rotate' because 'gracefully
putting nodes into and out of rotation' is an easier concept to grok.

> 2. rpmlint says: 
> 
> python-modjkapi.noarch: W: no-manual-page-for-binary bleeder
> python-modjkapi.src: W: strange-permission modjkapi-0.1.2.28.tar.gz 0660L
> 
> Might set the perms to 644? Or might be something odd on my end. 

Indeed, my umask was creating the sdist with those perms. This time before I
built the srpm I manually set the perms to the recommended 0644.

> The man page warning you can ignore...

Never

> ...but of course it's nice to add  a man page too. ;)

I agree. Therefore I have added a man page, as per your suggestion.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.