[Bug 707885] Review Request: rubygem-bson - Ruby implementation of BSON

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=707885

--- Comment #2 from Vít Ondruch <vondruch at redhat.com> 2011-05-26 08:44:33 EDT ---
(In reply to comment #1)
> My fist rubygem review, so be patient.
> 
> I suppose it's okay to define also other paths in 'gem install' than those
> stated in guidelines. -> --bindir .%{_bindir}

This avoids struggle with moving binaries and setting execution bits etc, so it
is the recommended approach.

> 
> You don't own: %{gemdir}/gems/%{gemname}-%{version}/ ,which you should own
> according guidelines.

I own %{geminstdir} which is the same I hope


> 
> Rpmlint is complaining.
> rpmlint rubygem-bson-1.3.1-1.fc16.src.rpm 
> rubygem-bson.src: W: invalid-url Source1: bson-tests.tgz

This is custom archive with files necessary to execute the test suite.

> rubygem-bson.noarch: W: no-documentation

Documentation is in subpackage.

> rubygem-bson.noarch: W: no-manual-page-for-binary b2json
> rubygem-bson.noarch: W: no-manual-page-for-binary j2bson

No manual pages. It is not common for rubygems to contains manual pages :/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.