[Bug 754698] Review Request: idjc - DJ application with streaming capabilities

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=754698

--- Comment #6 from Nikos Roussos <nikos at autoverse.net> 2011-11-28 05:28:14 EST ---
> * please extend the description to be more informative; now is too short; in
> this sense, maybe could be significative to explicit which formats are
> supported, expecially bc the Fedora packaging doesn't support some popular ones
> (correct me if I'm wrong)

You are right about this. I added a more detailed description. I don't see
necessary to explicitly point all the supported formats, as it actual supports
almost every free major audio format.

> * accordingly, IMHO would be appropiated to add a README.Fedora with the format support information explained

I think that upstream documentation already covers that.

> * I see idjc runs over JACK, AFAIK pulseaudio is the standard sound server in
> Fedora (I really only use GNOME so I ignore the details with the other
> desktop), so, is there any practical way to add the JACK integration with
> Pulseaudio? Maybe something launched by a shell script or equivalent... or just
> adding pulseaudio-module-jack as Requires: tag

Good idea! I could add pulseaudio-module-jack as dependency. It may not be
necessary for the application to run, but it make the life of a Fedorian much
more easier if he wishes to integrate it with other Pulseaudio apps.

> * Have you considered to include the html documentation?

done :)

> * Should be important to add a Requires: tag for icecast?

I don't think so. IDJC is just the client. Icecast could be on a different
machine. Certainly not a dependency.


> Checking list:
> 
> * Group: tag is wrong, use Applications/Multimedia
> 
> * the idjc.desktop file should include at least the AudioVideo category

Being a streaming application I find the Applications/Internet category more
appropriate.

> * Why you remove the Application category from idjc.desktop?

What Christoph said. It's no longer a valid category.

> PD: Completely out of this review, maybe you'll like to contrib a full featured idjc to RPM Fusion (something like idjc-freeworld)

Yeap. I plan to do so :)


New spec: http://comzeradd.fedorapeople.org/specs/idjc.spec
New SRPM:
http://repos.fedorapeople.org/repos/comzeradd/autoverse/fedora-16/SRPMS/idjc-0.8.6-3.fc16.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.