[Bug 719152] Review Request: gappalib-coq - Coq support library for gappa

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=719152

--- Comment #3 from Markus Mayer <LotharLutz at gmx.de> 2011-10-29 06:21:35 EDT ---
Unfortunatelly am not able to build you package:

ERROR:
+ ./configure --prefix=/usr --datadir=/usr/share
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking for coqc >= 8.3... /usr/bin/coqc
checking for coqdep... /usr/bin/coqdep
checking for ocamlc... no
checking for camlp5... /usr/bin/camlp5
checking for ocamlopt >= 3.11... which: no ocamlopt in
(/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin:/root/bin)

checking for Flocq... no
configure: error:  *** Unable to find the Flocq library
(http://flocq.gforge.inria.fr/)
error: Bad exit status from /var/tmp/rpm-tmp.w4N0kf (%build)

flocq is already installed!

Please fix this, so I can go on with reviewing your package.

Things I have already discovered:

- The naming guidelines says "If a new package is considered an "addon" package
that enhances or adds a new functionality to an existing Fedora package without
being useful on its own, its name should reflect this fact.

The new package ("child") should prepend the "parent" package in its name, in
the format: %{parent}-%{child}."

Therefor the package name should be "gaapa-coq". On the other hand it says
"When naming a package, the name should match the upstream tarball or project
name from which this software came." So gaapalib-coq would be correct to. I am
fine with both of them. Just take a look at the two names and decide for
yourself.

- Please use %{buildroot} instead of $RPM_BUILD_ROOT

- You could create a marco for the coq version. So you dont have to maintain it
on two places (Line 21 & 26 ).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.