[Bug 788815] Review Request: python-ZSI - python Zolera Soap Infrastructure

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=788815

--- Comment #2 from Tim Fenn <tim.fenn at gmail.com> 2012-02-09 21:44:13 EST ---
(In reply to comment #1)
> 
> Notes:
> * we can safely ignore rpmlint output since python-ZSI has existing EPEL5
> branch, the same for spelling errors.
> * fix upstream download url (the one in the spec is not working)
> http://belnet.dl.sourceforge.net/sourceforge/pywebsvcs/ZSI-2.0.tar.gz

Done.

> * prefer macro style over shell style s/$RPM_BUILD_ROOT/%{buildroot}/

Fixed.

> * you should ask upstream to include license text in source package (if they
> still answer)

Will do - I'll also ask re. the failed test (see below)

> * Though i won't consider this as a blocker, i strongly recommend you to run
> tests in %check section. All the more important since ZSI upstream is not
> responsive. For the few tests, that fails, i suggests you that you override
> tests exit code with "|| :". 
> That will help you monitoring ZSI health state during each release.

Done - one test fails, which I'll mention to upstream (there is also an alpha
2.1 release, it may be fixed there?)

> * i need to confirm that you're ok with the fact that ZSI is not actively
> maintained by upstream ? That means that you might have to fix by yourself
> FTBFS ou issues reported by users.
> 

It seems like there has been some work on the code in the past few months? 
I'll look into this further and try to contact upstream.  I'm mostly getting
this out to avoid breaking a dependency for another package I maintain (apbs) -
if upstream is silent here, I'll discuss with upstream of apbs about switching
to a different SOAP library.  If both of these approaches fail, I'll do my best
to handle problems that arise.

> 
> As long as you do the required changes above and you confirm that you will
> maintain it knowing that upstream might not be helpful, i may approve this
> package.

I understand - and thanks for the help getting this review done promptly!

New files:

Spec URL: https://sites.google.com/site/timfenn/python-ZSI.spec
SRPM URL: https://sites.google.com/site/timfenn/python-ZSI-2.0-11.fc16.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.