[Bug 788815] Review Request: python-ZSI - python Zolera Soap Infrastructure

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=788815

--- Comment #3 from Haïkel Guémar <karlthered at gmail.com> 2012-02-10 02:08:56 EST ---
Awesome !

i've mistakenly pasted the wrong download url in my review (i'm sorry, it's my
fault), it should be:
http://downloads.sourceforge.net/project/pywebsvcs/ZSI/ZSI-%{version}/ZSI-%{version}.tar.gz

A quick test:
urlgrabber
http://downloads.sourceforge.net/project/pywebsvcs/ZSI/ZSI-2.0/ZSI-2.0.tar.gz

The mock build fails due to tests
http://koji.fedoraproject.org/koji/taskinfo?taskID=3777577

Since tests doesn't modify their sys.path, they fail to find the ZSI module
(which is not installed yet). To fix that, you can add the ZSI directory to
PYTHONPATH environment variable. PyXML will also be needed as a BR.
I have one more failing tests (the TCtimes one).

Here's a scratch build of a slightly modified version of your package that
builds inside mock.
http://koji.fedoraproject.org/koji/taskinfo?taskID=3777593

As soon as you fix the download url, i'll approve this package. Save that, it's
all green for me.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.