[Bug 788080] Review Request: python-xhtml2pdf - HTML/CSS to PDF converter based on Python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=788080

--- Comment #4 from Brendan Jones <brendan.jones.it at gmail.com> 2012-02-17 18:46:12 EST ---
Looking good - just a couple of things. I've done the formal review, but just
need to run these by you.

1. rpmlint on the built package:
python-xhtml2pdf.noarch: E: explicit-lib-dependency python-html5lib
python-xhtml2pdf.noarch: E: explicit-lib-dependency python-httplib2
Can you remove these?

2. Just for completeness use your %{pkgname} var in the %files section

3. Build is failing on koji in the %test section:

http://koji.fedoraproject.org/koji/taskinfo?taskID=3800044 - it is try to pull
down the reportlab egg

4. Just a note: it seems to be bundling some of the reportlab source.
/usr/lib64/python2.7/site-packages/reportlab/platypus/paragraph.py
vs.
xhtml2pdf/reportlab_paragraph.py
However it seems that this has been heavily modified, quite well annotated and
doesn't breach the reportlab license (BSD) so no blocker.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.