[Bug 788080] Review Request: python-xhtml2pdf - HTML/CSS to PDF converter based on Python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=788080

--- Comment #5 from Matthias Runge <mrunge at matthias-runge.de> 2012-02-20 04:51:50 EST ---
Thank you for your remarks, I tried to fix them (if possible)

Those explicit dependencies are, imho falso positives from rpmlint. If left
out, the package does not work, because of broken imports.

[mrunge at mrungexp SPECS]$ diff -u python-xhtml2pdf.spec.2 python-xhtml2pdf.spec
--- python-xhtml2pdf.spec.2 2012-02-13 11:58:38.000000000 +0100
+++ python-xhtml2pdf.spec 2012-02-20 10:44:32.734080127 +0100
@@ -2,7 +2,7 @@

 Name:           python-xhtml2pdf
 Version:        0.0.3
-Release:        2%{?dist}
+Release:        3%{?dist}
 Summary:        HTML/CSS to PDF converter based on Python

 # licensed under ASL 2.0 and BSD-License
@@ -19,9 +19,18 @@
 BuildRequires:  python-nose
 BuildRequires:  pyPdf

+# required for testing:
+BuildRequires:       python-reportlab
+BuildRequires:       python-imaging
+BuildRequires:       python-html5lib
+BuildRequires:       python-httplib2
+
 Requires:       pyPdf
 Requires:       python-reportlab
 Requires:       python-imaging
+
+# removing will create rpmlint-false positive
+# html5lib and httplib both are requires to work
 Requires:       python-html5lib
 Requires:       python-httplib2

@@ -58,10 +67,14 @@
 %{python_sitelib}/%{pkgname}-%{version}-py?.?.egg-info
 %{python_sitelib}/%{pkgname}/
 %{_bindir}/pisa
-%{_bindir}/xhtml2pdf
+%{_bindir}/%{pkgname}


 %changelog
+* Mon Feb 20 2012 Matthias Runge <mrunge at matthias-runge.de> - 0.0.3-3
+- fix tests to complete testing
+- add comment about required html5lib and httplib2
+
 * Mon Feb 13 2012 Matthias Runge <mrunge at matthias-runge.de> - 0.0.3-2
 - be more explicit in %%files-section


Package now builds in koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3804269
(sorry for this, I should have done this earlier)

updated SPEC: http://www.matthias-runge.de/fedora/python-xhtml2pdf.spec
updated SRPM:
http://www.matthias-runge.de/fedora/python-xhtml2pdf-0.0.3-3.fc16.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.