[Bug 799089] Review Request: dyninst - An API for Run-time Code Generation

bugzilla at redhat.com bugzilla at redhat.com
Thu Mar 15 21:56:49 UTC 2012


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=799089

--- Comment #5 from Josh Stone <jistone at redhat.com> 2012-03-15 17:56:49 EDT ---
(In reply to comment #4)
> MUST: not bundle system libraries
>       - boost is bundled, and is even installed into dyninst-devel.
>       (it looks like one can just add a BuildReqs: boost-deve and nuke the
>        boost subdirectory)

Did you notice that boost actually exists twice?

$ find -name boost
./dyninstAPI/src/dyninst/external/boost
./dyninstAPI/src/dyninst/dynutil/h/dyn_detail/boost

The latter is just a subset, and a few files that I compared look identical,
except namespaced everywhere as "dyn_detail::".  It appears to be included and
used by that explicit path and namespace in quite a few places.  It may still
be possible to patch that out, but not as trivial as nuking a subdirectory...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list