[Bug 807472] Review Request: libstoragemgmt - Library for storage array management

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=807472

--- Comment #4 from Tony Asleson <tasleson at redhat.com> 2012-03-29 19:10:35 EDT ---
Thank you for the review Michael!

> Correct. You also need it behind %{python_sitelib} for exactly the reason
> you've given.

Done

>> Summary:        A library for storage array management
> 
> The majority of package summaries omit leading articles, which makes them much
> more pretty when displayed in in Anaconda (and package tools).

Done

>> Requires:       %{name} = %{version}-%{release}
> 
> https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package

Done

>> %post 
>> /sbin/ldconfig
> 
> Just want to point out, this means that there is no automatic dependency on
> /sbin/ldconfig.

Are you suggesting I make an explicit dependency for this?

>> %files devel
>> %defattr(-,root,root,-)
>> %doc README COPYING.LIB
> 
> https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing

Done

Spec file updated.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.