[PATCH 19/21] Stop making source files read-only
Mathieu Bridon
bochecha at fedoraproject.org
Wed May 6 11:53:15 UTC 2015
From: Mathieu Bridon <bochecha at daitauha.fr>
These lines are trying to ensure that we can read the file content, and
being able to read it is of course necessary if we're uploading it.
However, a few lines above, we actually computed the hash of the file,
which... required being able to read it.
So if the file wasn't readable, we'd have failed much earlier anyway,
which makes those two lines useless.
In addition, they make the file read-only, which is annoying for package
maintainers when try to remove it, as they then require a confirmation.
---
src/pyrpkg/__init__.py | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/pyrpkg/__init__.py b/src/pyrpkg/__init__.py
index 23b67a7..a8ca735 100644
--- a/src/pyrpkg/__init__.py
+++ b/src/pyrpkg/__init__.py
@@ -25,7 +25,6 @@ import rpm
import logging
import git
import ConfigParser
-import stat
import tempfile
import fnmatch
import urlparse
@@ -2231,8 +2230,6 @@ class Commands(object):
else:
self.log.info("Uploading: %s %s" % (file_hash, f))
- # Ensure the new file is readable:
- os.chmod(f, stat.S_IRUSR | stat.S_IRGRP | stat.S_IROTH)
self._do_curl(file_hash, f)
uploaded.append(file_basename)
--
2.1.0
More information about the rel-eng
mailing list