[PATCH 20/21] Remove unnecessary log message

Mathieu Bridon bochecha at fedoraproject.org
Wed May 6 11:53:16 UTC 2015


From: Mathieu Bridon <bochecha at daitauha.fr>

We are already logging each file we are uploading, so there really is no
need to add such a summary at the end.

Removing it also makes the code simpler, as we don't need to keep track
of the list of uploaded files any more.
---
 src/pyrpkg/__init__.py | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/pyrpkg/__init__.py b/src/pyrpkg/__init__.py
index a8ca735..391085c 100644
--- a/src/pyrpkg/__init__.py
+++ b/src/pyrpkg/__init__.py
@@ -2197,7 +2197,6 @@ class Commands(object):
                                replace=replace)
         gitignore = GitIgnore(os.path.join(self.path, '.gitignore'))
 
-        uploaded = []
         for f in files:
             # TODO: Skip empty file needed?
             file_hash = self.lookasidecache.hash_file(f)
@@ -2231,7 +2230,6 @@ class Commands(object):
             else:
                 self.log.info("Uploading: %s  %s" % (file_hash, f))
                 self._do_curl(file_hash, f)
-                uploaded.append(file_basename)
 
         sourcesf.write()
         gitignore.write()
@@ -2241,10 +2239,6 @@ class Commands(object):
         # Change back to original working dir:
         os.chdir(oldpath)
 
-        # Log some info
-        self.log.info('Uploaded and added to .gitignore: %s' %
-                      ' '.join(uploaded))
-
     def prep(self, arch=None, builddir=None):
         """Run rpm -bp on a module
 
-- 
2.1.0



More information about the rel-eng mailing list