fedora-review ruby plugin

Alec Leamas leamas.alec at gmail.com
Mon May 25 10:36:56 UTC 2015


On 22/05/15 15:40, Josef Stribny wrote:
> Hi,
>
> so I looked on the results from running your latest changes and I found
> one problem.
>
> It's the GemCheckUsesMacros check, which does not seem to work as expected.
>
> Excerpt from the review:
>
> Ruby:
> 151 [ ]: Specfile should use macros from rubygem-devel package.
> 152      Note: The specfile doesn't use these macros: %exclude
> 153      /usr/share/gems/cache/spring-1.3.6.gem,
> 154      /usr/share/gems/specifications/spring-1.3.6.gemspec
>

Thanks for a really good catch! It turned out that this was because 
spec_file.py didn't parse the %files section correctly.

It's actually a pain, but although rpm implements the spec file parsing 
there is no interface to retrieve the raw text. I have had a rpm patch 
reviewed adding an interface, but it was rejected :(

The changes are yet not checked in, but later today I will probably 
merge the ruby-f22 branch.

Cheers!

--alec



More information about the ruby-sig mailing list