devel/kphone kphone.spec,1.2,1.3

[Ralf Corsepius]

On Wed, 2005-03-16 at 18:42 -0500, Ignacio Vazquez-Abrams wrote:
> Author: ivazquez
> 
> Update of /cvs/extras/devel/kphone
> In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv19161/kphone
> 
> Modified Files:
> 	kphone.spec 
> Log Message:
> More review fixes

>  ./configure --prefix=$RPM_BUILD_ROOT%{_prefix}

A prefix containing $RPM_BUILD_ROOT hardly can be correct.
You probably want %configure


Furthermore, I am not convinced about this package's sources quality:

- The tarballs is badly packaged:
+ tar -xf -
tar: kphone/dissipate2: implausibly old time stamp 1970-01-01 01:00:00
tar: kphone/gsm: implausibly old time stamp 1970-01-01 01:00:00
tar: kphone/icons: implausibly old time stamp 1970-01-01 01:00:00
tar: kphone/ilbc: implausibly old time stamp 1970-01-01 01:00:00
tar: kphone/kphone: implausibly old time stamp 1970-01-01 01:00:00
tar: Read 7168 bytes from -
tar: kphone/po: implausibly old time stamp 1970-01-01 01:00:00
tar: kphone: implausibly old time stamp 1970-01-01 01:00:00
+ STATUS=0

- Serious compiler warnings:
In file included from dspoutrtp.cpp:16:
rtpdataheader.h:35: warning: `__packed__' attribute ignored
(I didn't investigate potential issues being caused by this warning.)

- This package does not acknowledge RPM_OPT_FLAGS
(This package's configuration is ..., to say the least ...)


Below is a patch to workaround the prefix issue.

Ralf

-------------- next part --------------
A non-text attachment was scrubbed...
Name: kphone-4.1.0-po-hacks.diff
Type: text/x-patch
Size: 478 bytes
Desc: not available
Url : http://lists.fedoraproject.org/pipermail/scm-commits/attachments/20050317/8f7cde0a/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kphone.spec.diff
Type: text/x-patch
Size: 1101 bytes
Desc: not available
Url : http://lists.fedoraproject.org/pipermail/scm-commits/attachments/20050317/8f7cde0a/attachment-0001.bin