devel/kphone kphone.spec,1.2,1.3

[Ignacio Vazquez-Abrams]

On Thu, 2005-03-17 at 09:29 +0100, Ralf Corsepius wrote:
> On Wed, 2005-03-16 at 18:42 -0500, Ignacio Vazquez-Abrams wrote:
> >  ./configure --prefix=$RPM_BUILD_ROOT%{_prefix}
> 
> A prefix containing $RPM_BUILD_ROOT hardly can be correct.
> You probably want %configure

Yes. I'll fix it.

> Furthermore, I am not convinced about this package's sources quality:

> tar: kphone/dissipate2: implausibly old time stamp 1970-01-01 01:00:00

I agree that it looks flaky, but that's exactly how it's found on the
site.

> - Serious compiler warnings:
> In file included from dspoutrtp.cpp:16:
> rtpdataheader.h:35: warning: `__packed__' attribute ignored
> (I didn't investigate potential issues being caused by this warning.)

Well, the attribute is on a bitfield dword-aligned struct so it should
be fine on 32-bit archs. On 64-bit archs it may have runtime failures
unless alignment is dword-forced.

Also, looking into it reveals that the package probably won't run
properly on big-endian archs. Unfortunately I don't have enough endian
experience to construct a universal patch.

> - This package does not acknowledge RPM_OPT_FLAGS
> (This package's configuration is ..., to say the least ...)

It was one of my first with FC3, so I'm not surprised that it's a piece
of ....

> Below is a patch to workaround the prefix issue.

I'll apply it, thanks.

-- 
Ignacio Vazquez-Abrams <ivazquez at ivazquez.net>
http://fedora.ivazquez.net/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.fedoraproject.org/pipermail/scm-commits/attachments/20050317/c3ba87c2/attachment.bin