[perl-Tk-Text-SuperText] Attempt at saner SPEC file formatting
Lubomir Rintel
lkundrak at fedoraproject.org
Thu Oct 24 09:53:16 UTC 2013
commit 4bbbd3715b4d24df9eb2db961ae5421962308230
Author: Lubomir Rintel <lkundrak at v3.sk>
Date: Thu Oct 24 11:39:54 2013 +0200
Attempt at saner SPEC file formatting
I'm doing this semi-automatically across all packages I maintain, since some
are several years old and since then several have suffered bit-rot and such.
I'm fixing up the following:
- Old RPM relics (such as %defattr, BuildRoot or %clean sections)
- Whitespace errors (such as trailing spaces)
- Consistent use of %{buildroot}
- Dropping useless %{name} expansions that harm legibility
- Consistent spacing between RPM sections
- Bad days in %changelogs
perl-Tk-Text-SuperText.spec | 23 +++++++++--------------
1 files changed, 9 insertions(+), 14 deletions(-)
---
diff --git a/perl-Tk-Text-SuperText.spec b/perl-Tk-Text-SuperText.spec
index 4e9165b..ef37e66 100644
--- a/perl-Tk-Text-SuperText.spec
+++ b/perl-Tk-Text-SuperText.spec
@@ -1,6 +1,6 @@
Name: perl-Tk-Text-SuperText
Version: 0.9.4
-Release: 11%{?dist}
+Release: 12%{?dist}
Summary: Improved text widget for perl/tk
License: GPL+ or Artistic
Group: Development/Libraries
@@ -8,7 +8,6 @@ URL: http://search.cpan.org/dist/Tk-Text-SuperText/
Source0: http://www.cpan.org/authors/id/A/AL/ALEXIOB/Tk-Text-SuperText-%{version}.tar.gz
Patch0: perl-Tk-Text-SuperText-0.9.4-hashref.patch
Patch1: perl-Tk-Text-SuperText-0.9.4-test.patch
-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
BuildArch: noarch
BuildRequires: perl(ExtUtils::MakeMaker)
BuildRequires: perl(Tk)
@@ -39,14 +38,12 @@ make %{?_smp_mflags}
%install
-rm -rf $RPM_BUILD_ROOT
+make pure_install PERL_INSTALL_ROOT=%{buildroot}
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
+find %{buildroot} -type f -name .packlist -exec rm -f {} \;
+find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \;
-find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;
-find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
-
-%{_fixperms} $RPM_BUILD_ROOT/*
+%{_fixperms} %{buildroot}/*
%check
@@ -56,18 +53,16 @@ xinit %{_bindir}/make -s test -- %{_bindir}/Xvfb :666 |tee testing.TAP
prove --exec cat testing.TAP
-%clean
-rm -rf $RPM_BUILD_ROOT
-
-
%files
-%defattr(-,root,root,-)
%doc README
%{perl_vendorlib}/*
%{_mandir}/man3/*
%changelog
+* Thu Oct 24 2013 Lubomir Rintel (GoodData) <lubo.rintel at gooddata.com> - 0.9.4-12
+- Bulk sad and useless attempt at consistent SPEC file formatting
+
* Sun Aug 04 2013 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 0.9.4-11
- Rebuilt for https://fedoraproject.org/wiki/Fedora_20_Mass_Rebuild
@@ -99,7 +94,7 @@ rm -rf $RPM_BUILD_ROOT
- Formatting/wording fixes (Peter Pisar)
- Actually run the test suite (Peter Pisar)
-* Tue Jun 09 2009 Lubomir Rintel (Good Data) <lubo.rintel at gooddata.com> 0.9.4-1
+* Tue Jun 09 2009 Lubomir Rintel (GoodData) <lubo.rintel at gooddata.com> 0.9.4-1
- Specfile autogenerated by cpanspec 1.78.
- Fix up license
- Fix test warnings
More information about the scm-commits
mailing list