[perl-WWW-GoodData] Attempt at saner SPEC file formatting
Lubomir Rintel
lkundrak at fedoraproject.org
Thu Oct 24 09:53:32 UTC 2013
commit e7455954408e9619f36237cc74cd2f9c69c6b9a5
Author: Lubomir Rintel <lkundrak at v3.sk>
Date: Thu Oct 24 11:39:54 2013 +0200
Attempt at saner SPEC file formatting
I'm doing this semi-automatically across all packages I maintain, since some
are several years old and since then several have suffered bit-rot and such.
I'm fixing up the following:
- Old RPM relics (such as %defattr, BuildRoot or %clean sections)
- Whitespace errors (such as trailing spaces)
- Consistent use of %{buildroot}
- Dropping useless %{name} expansions that harm legibility
- Consistent spacing between RPM sections
- Bad days in %changelogs
perl-WWW-GoodData.spec | 25 ++++++++++---------------
1 files changed, 10 insertions(+), 15 deletions(-)
---
diff --git a/perl-WWW-GoodData.spec b/perl-WWW-GoodData.spec
index 0bffcc3..41a0023 100644
--- a/perl-WWW-GoodData.spec
+++ b/perl-WWW-GoodData.spec
@@ -1,12 +1,11 @@
Name: perl-WWW-GoodData
Version: 1.10
-Release: 1%{?dist}
+Release: 2%{?dist}
Summary: Client library for GoodData REST-ful API
License: GPL+ or Artistic
Group: Development/Libraries
URL: http://search.cpan.org/dist/WWW-GoodData/
Source0: http://www.cpan.org/authors/id/L/LK/LKUNDRAK/WWW-GoodData-%{version}.tar.gz
-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
BuildArch: noarch
BuildRequires: perl(IO::Socket::SSL)
BuildRequires: perl(JSON)
@@ -32,24 +31,17 @@ correctness of implementation.
%install
-rm -rf $RPM_BUILD_ROOT
+./Build install destdir=%{buildroot} create_packlist=0
+find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \;
-./Build install destdir=$RPM_BUILD_ROOT create_packlist=0
-find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
-
-%{_fixperms} $RPM_BUILD_ROOT/*
+%{_fixperms} %{buildroot}/*
%check
./Build test
-%clean
-rm -rf $RPM_BUILD_ROOT
-
-
%files
-%defattr(-,root,root,-)
%doc ISSUES
%{perl_vendorlib}/*
%{_bindir}/gdc
@@ -58,6 +50,9 @@ rm -rf $RPM_BUILD_ROOT
%changelog
+* Thu Oct 24 2013 Lubomir Rintel (GoodData) <lubo.rintel at gooddata.com> - 1.10-2
+- Bulk sad and useless attempt at consistent SPEC file formatting
+
* Mon Aug 12 2013 Lubomir Rintel (GoodData) <lubo.rintel at gooddata.com> 1.10-1
- Rebase
@@ -85,12 +80,12 @@ rm -rf $RPM_BUILD_ROOT
* Sat Jun 16 2012 Petr Pisar <ppisar at redhat.com> - 1.6-2
- Perl 5.16 rebuild
-* Mon Feb 13 2012 Lubomir Rintel (Good Data) <lubo.rintel at gooddata.com> 1.6-1
+* Mon Feb 13 2012 Lubomir Rintel (GoodData) <lubo.rintel at gooddata.com> 1.6-1
- Rebase
-* Mon Aug 15 2011 Lubomir Rintel (Good Data) <lubo.rintel at gooddata.com> 1.4-2
+* Mon Aug 15 2011 Lubomir Rintel (GoodData) <lubo.rintel at gooddata.com> 1.4-2
- Remove redundant requires
- Fix a typo in description
-* Mon Aug 08 2011 Lubomir Rintel (Good Data) <lubo.rintel at gooddata.com> 1.4-1
+* Mon Aug 08 2011 Lubomir Rintel (GoodData) <lubo.rintel at gooddata.com> 1.4-1
- Specfile autogenerated by cpanspec 1.78.
More information about the scm-commits
mailing list